Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove all of machinery from distillery/main.dm from all the maps exept big red. #5425

Closed
wants to merge 1 commit into from
Closed

remove all of machinery from distillery/main.dm from all the maps exept big red. #5425

wants to merge 1 commit into from

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Jan 11, 2024 •
edited by github-actions bot
Loading

About the pull request

Part of the plan to remove those obsolete machinery those must be purged...

Explain why it's good for the game

Part of the plan to remove those obsolete machinery

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
maptweak: remove all of machinery from distillery/main.dm from all the maps except big red.
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Jan 11, 2024
@Huffie56 Huffie56 marked this pull request as ready for review January 11, 2024 13:46
Nanu308
Nanu308 requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are still used as map props for looks, change the machinery to keep the icon/desc and name then swap out the filepath for something else.

@Nanu308 Nanu308 marked this pull request as draft January 11, 2024 17:13
@Huffie56
Copy link
Contributor Author

They are still used as map props for looks, change the machinery to keep the icon/desc and name then swap out the filepath for something else.

i am not sure what you mean there.....
but this PR is to remove them all from maps that don't have a PR on them currently.

I already have a PR to turn them into prop.(tackling this file from two separate angle...)
#5424

so if you think we should keep them as prop (when they use auto-lathe sprite and just have a different name and description)
just tell me i will close this PR it's fine...

@Huffie56 Huffie56 requested a review from Nanu308 January 11, 2024 17:25
@Huffie56
Copy link
Contributor Author

closing because they will just be turn into prop not removed totally...

@Huffie56 Huffie56 closed this Jan 11, 2024
@Huffie56 Huffie56 deleted the remove_old_machine branch January 24, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nanu308 Nanu308 Awaiting requested review from Nanu308 Nanu308 is a code owner

Assignees
No one assigned
Labels
Mapping did you remember to save in tgm format?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Huffie56 @Nanu308